alexeykudinkin commented on code in PR #5943: URL: https://github.com/apache/hudi/pull/5943#discussion_r931583487
########## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/parser/HoodieCommonSqlParser.scala: ########## @@ -57,6 +57,14 @@ class HoodieCommonSqlParser(session: SparkSession, delegate: ParserInterface) override def parseDataType(sqlText: String): DataType = delegate.parseDataType(sqlText) + /* SPARK-37266 Added parseQuery to ParserInterface in Spark 3.3.0. This is a patch to prevent + hackers from tampering text with persistent view, it won't be called in older Spark + Don't mark this as override for backward compatibility + Can't use sparkExtendedParser directly here due to the same reason */ Review Comment: As discussed on Slack, let's instead of doing parsing in `SparkAdapter` create `ExtendedParserInterface`, where we can place this new `parseQuery` method and that could be used in Hudi's code-base (this is similar to how `HoodieCatalystExpressionUtils` set up) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
