xushiyan commented on code in PR #6229: URL: https://github.com/apache/hudi/pull/6229#discussion_r931625350
########## hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestAWSDatabaseMigrationServiceSource.java: ########## @@ -18,7 +18,7 @@ package org.apache.hudi.utilities.functional; -import org.apache.hudi.common.model.AWSDmsAvroPayload; +import org.apache.hudi.payload.AWSDmsAvroPayload; Review Comment: ditto ########## hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/AWSDmsTransformer.java: ########## @@ -19,8 +19,8 @@ package org.apache.hudi.utilities.transform; import org.apache.hudi.common.config.TypedProperties; -import org.apache.hudi.common.model.AWSDmsAvroPayload; import org.apache.hudi.common.util.Option; +import org.apache.hudi.payload.AWSDmsAvroPayload; import org.apache.spark.api.java.JavaSparkContext; Review Comment: why this change? the old class is not meant for bwc where users are loading the class via FQCN. internal codebase should always use the new class. ########## hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java: ########## @@ -18,7 +18,6 @@ package org.apache.hudi.payload; -import org.apache.hudi.common.model.AWSDmsAvroPayload; Review Comment: can this test be moved to hudi-common? where the tested class belongs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
