danny0405 commented on code in PR #6100:
URL: https://github.com/apache/hudi/pull/6100#discussion_r931955965
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -502,6 +503,21 @@ private FlinkOptions() {
.defaultValue(true) // default true for MOR write
.withDescription("Schedule the compaction plan, enabled by default for
MOR");
+ public static final ConfigOption<String> COMPACTION_SCHEDULE_SEQ =
ConfigOptions
+ .key("compaction.schedule.seq")
+ .stringType()
+ .defaultValue(FlinkCompactionConfig.SEQ_FIFO) // default LIFO to
improve compact stability
+ .withDescription("Compaction plan execution sequence, two options are
supported:\n"
+ + "1). FIFO: execute the oldest plan first;\n"
+ + "2). LIFO: execute the latest plan first, by default FIFO\n"
+ + "3). DYNAMIC: schedule the plan seq dynamic");
+
+ public static final ConfigOption<Integer> PENDING_PLAN_NUM = ConfigOptions
+ .key("pending.plan_num")
+ .intType()
Review Comment:
Can we avoid these options and make the strategy as default ? We can use a
threshold here like 10 pending compaction plans to switch from `FIFO` to `LIFO`.
`compaction.fifo.max.pending.plans`
Default make the value 0 to mean we never switch that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
