nsivabalan commented on code in PR #5245:
URL: https://github.com/apache/hudi/pull/5245#discussion_r932573326
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1113,9 +1113,28 @@ protected Map<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInfos
protected Map<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInfos(HoodieTableMetaClient metaClient, boolean
ignoreCompactionAndClusteringInstants) {
List<HoodieInstant> instants =
metaClient.getActiveTimeline().filterPendingRollbackTimeline().getInstants().collect(Collectors.toList());
Map<String, Option<HoodiePendingRollbackInfo>> infoMap = new HashMap<>();
- for (HoodieInstant instant : instants) {
+ for (HoodieInstant rollbackInstant : instants) {
+ HoodieRollbackPlan rollbackPlan;
+ try {
+ rollbackPlan = RollbackUtils.getRollbackPlan(metaClient,
rollbackInstant);
+ } catch (IOException e) {
Review Comment:
yeah. Ethan reminded me of the same discussion we had when the patch was put
up. we found the existing fix as the safest option compared to other
alternatives. Just to add to what Ethan has mentioned above, we do this only
incase of rollback.requested and not for rollback.inflight. For inflight, its
safe to re-use the plan from the rollback.requested file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
