vinothchandar commented on a change in pull request #1471: [WIP][HUDI-752]Make CompactionAdminClient spark-free URL: https://github.com/apache/incubator-hudi/pull/1471#discussion_r400972550
########## File path: hudi-client/src/main/java/org/apache/hudi/client/utils/SparkEngineUtils.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client.utils; + +import org.apache.spark.SparkContext; +import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.api.java.function.FlatMapFunction; +import org.apache.spark.api.java.function.Function; + +import java.util.List; + +/** + * Util class for Spark Engine. + */ +public class SparkEngineUtils { Review comment: I understand the spirit here.. but if we are introducing an abstraction like `SparkEngineUtils`, then we need more upfront design on how its going to fit in everywhere.. thoughts? If we can produce such an abstraction, then we need not do this piecemeal like class by class.. we can see if this model can replace the core writing logic and you can run the TestCopyOnWriteStorage..... unit test successfully.. I think thats a better parallel approach to pursue... I have scoped the work for HUDI-677 , which will move a bunch of code.. So also love to avoid stepping on toes for this week atleast :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
