codope commented on code in PR #5943:
URL: https://github.com/apache/hudi/pull/5943#discussion_r933778276
##########
pom.xml:
##########
@@ -1664,23 +1665,24 @@
</activation>
</profile>
- <!-- spark3 is an alias of spark3.2 -->
+ <!-- spark3 is an alias of spark3.3 -->
<profile>
<id>spark3</id>
<properties>
- <spark3.version>3.2.1</spark3.version>
+ <spark3.version>3.3.0</spark3.version>
<spark.version>${spark3.version}</spark.version>
- <sparkbundle.version>3</sparkbundle.version>
+ <sparkbundle.version>3.3</sparkbundle.version>
<scala.version>${scala12.version}</scala.version>
<scala.binary.version>2.12</scala.binary.version>
- <hudi.spark.module>hudi-spark3</hudi.spark.module>
+ <hudi.spark.module>hudi-spark3.3.x</hudi.spark.module>
Review Comment:
same here. should we keep it hudi-spark3?
##########
pom.xml:
##########
@@ -1664,23 +1665,24 @@
</activation>
</profile>
- <!-- spark3 is an alias of spark3.2 -->
+ <!-- spark3 is an alias of spark3.3 -->
<profile>
<id>spark3</id>
<properties>
- <spark3.version>3.2.1</spark3.version>
+ <spark3.version>3.3.0</spark3.version>
<spark.version>${spark3.version}</spark.version>
- <sparkbundle.version>3</sparkbundle.version>
+ <sparkbundle.version>3.3</sparkbundle.version>
Review Comment:
Shouldn't `sparkbundle.version` still be `3` for this profilie? After
building code with -Dspark3 option, I see the bundle named
`hudi-spark3.3-bundle-*` instead of `hudi-spark3-bundle-*`. Is that expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
