danny0405 commented on code in PR #6257:
URL: https://github.com/apache/hudi/pull/6257#discussion_r934084158
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java:
##########
@@ -84,6 +84,9 @@ public static HiveSyncContext create(Configuration conf,
SerializableConfigurati
org.apache.hadoop.conf.Configuration hadoopConf =
HadoopConfigurations.getHadoopConf(conf);
HiveConf hiveConf = new HiveConf();
hiveConf.addResource(serConf.get());
+ if (!FlinkOptions.isDefaultValueDefined(conf,
FlinkOptions.HIVE_SYNC_METASTORE_URIS)) {
+ hadoopConf.set(HiveConf.ConfVars.METASTOREURIS.varname,
conf.getString(FlinkOptions.HIVE_SYNC_METASTORE_URIS));
+ }
Review Comment:
Not sure what this patch is fixing for, shouldn't the `buildSyncConfig`
already take care of this config option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
