KnightChess commented on code in PR #6225:
URL: https://github.com/apache/hudi/pull/6225#discussion_r934096061
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala:
##########
@@ -62,12 +65,22 @@ case class CreateHoodieTableCommand(table: CatalogTable,
ignoreIfExists: Boolean
// check if there are conflict between table configs defined in hoodie
table and properties defined in catalog.
CreateHoodieTableCommand.validateTblProperties(hoodieCatalogTable)
- // init hoodie table
- hoodieCatalogTable.initHoodieTable()
+ val queryAsProp =
hoodieCatalogTable.catalogProperties.get(ConfigUtils.IS_QUERY_AS_RO_TABLE)
+ if (queryAsProp.isEmpty) {
Review Comment:
If the table not exsit, queryAsProp may not need to check. I want to create
a not exsit mor table with `hoodie.query.as.ro.table=false`, I think need to
consider this scene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
