f7753 commented on code in PR #6218:
URL: https://github.com/apache/hudi/pull/6218#discussion_r934517252
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -137,7 +136,7 @@ public static DataStreamSink<Object>
bulkInsert(Configuration conf, RowType rowT
// use #partitionCustom instead of #keyBy to avoid duplicate sort
operations,
// see BatchExecutionUtils#applyBatchExecutionSettings for details.
Partitioner<String> partitioner = (key, channels) ->
- KeyGroupRangeAssignment.assignKeyToParallelOperator(key,
StreamGraphGenerator.DEFAULT_LOWER_BOUND_MAX_PARALLELISM, channels);
+ KeyGroupRangeAssignment.assignKeyToParallelOperator(key,
KeyGroupRangeAssignment.UPPER_BOUND_MAX_PARALLELISM, channels);
dataStream = dataStream.partitionCustom(partitioner,
rowDataKeyGen::getPartitionPath);
Review Comment:
Could I use `conf.getInteger(FlinkOptions.WRITE_TASKS)` directly?
```java
// shuffle by partition keys
// use #partitionCustom instead of #keyBy to avoid duplicate sort operations,
// see BatchExecutionUtils#applyBatchExecutionSettings for details.
Partitioner<String> partitioner = (key, channels) ->
KeyGroupRangeAssignment.assignKeyToParallelOperator(key,
conf.getInteger(FlinkOptions.WRITE_TASKS), channels);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
