YuweiXiao commented on code in PR #6273:
URL: https://github.com/apache/hudi/pull/6273#discussion_r935320724
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -378,6 +379,28 @@ private void startInstant() {
this.conf.getString(FlinkOptions.TABLE_NAME),
conf.getString(FlinkOptions.TABLE_TYPE));
}
+ /**
+ * Get the valid instant time of last batch from bootstrap events
+ * Return Option.empty() to indicate the instant is invalid from last batch
+ */
+ protected Option<String> bootstrapInstantFromEventBuffer() {
+ ValidationUtils.checkArgument(Arrays.stream(eventBuffer).allMatch(evt ->
evt != null && evt.isBootstrap()));
+ List<WriteMetadataEvent> events = Arrays.stream(eventBuffer).filter(evt ->
!evt.getInstantTime().equals("")).collect(Collectors.toList());
+ String instant =
events.stream().map(WriteMetadataEvent::getInstantTime).reduce((a, b) ->
a.equals(b) ? a : "").orElse("");
+ // instant and parallelism should be unique
Review Comment:
Yes, and those empty event will be excluded as the instant time is empty.
Lets say we increase `write.task` from 4 -> 8. During restart, we will
receive 8 metadata event (with 4 empty bootstrap event and potentially more if
some tasks failed to flush in the last run). In order to do know if the
remaining non-empty metadata events are the full collection of events from last
run, we have to get the parallelism of the last run (i.e., 4) rather than
checking using the new parallelism (i.e., 8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
