alexeykudinkin commented on code in PR #5629:
URL: https://github.com/apache/hudi/pull/5629#discussion_r938157656
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -124,12 +126,17 @@ public class HoodieWriteConfig extends HoodieConfig {
.withDocumentation("Payload class used. Override this, if you like to
roll your own merge logic, when upserting/inserting. "
+ "This will render any value set for PRECOMBINE_FIELD_OPT_VAL
in-effective");
- public static final ConfigProperty<String> MERGE_CLASS_NAME = ConfigProperty
+ public static final ConfigProperty<String> MERGER_CLASS_NAME = ConfigProperty
Review Comment:
We probably fine either way, but for simplicity i'd suggest we stick with
our current approach of keeping it table-property:
1. It's easier for users to understand (existing behavior)
2. It stays part of the table's (immutable) configuration, avoiding the toll
of needing to specify it explicitly with every write (could be error-prone)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
