codope commented on code in PR #6227:
URL: https://github.com/apache/hudi/pull/6227#discussion_r938462895
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala:
##########
@@ -223,6 +215,20 @@ private[sql] class AvroSerializer(
val numFields = st.length
(getter, ordinal) => structConverter(getter.getStruct(ordinal,
numFields))
+
////////////////////////////////////////////////////////////////////////////////////////////
+ // Following section is amended to the original (Spark's) implementation
+ // >>> BEGINS
+
////////////////////////////////////////////////////////////////////////////////////////////
+
+ case (st: StructType, UNION) =>
Review Comment:
Very good point! Sounds good. Let's make sure that the annotation is common
across code, easily searchable. Probably, we should put this in coding
guidelines as well?
https://hudi.apache.org/contribute/developer-setup#coding-guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
