nsivabalan commented on code in PR #6266:
URL: https://github.com/apache/hudi/pull/6266#discussion_r939107205
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/MarkerBasedRollbackUtils.java:
##########
@@ -54,25 +64,35 @@ public static List<String> getAllMarkerPaths(HoodieTable
table, HoodieEngineCont
String instant, int
parallelism) throws IOException {
String markerDir = table.getMetaClient().getMarkerFolderPath(instant);
FileSystem fileSystem = table.getMetaClient().getFs();
- Option<MarkerType> markerTypeOption =
MarkerUtils.readMarkerType(fileSystem, markerDir);
+ Option<MarkerType> markerTypeOption = readMarkerType(fileSystem,
markerDir);
- // If there is no marker type file "MARKERS.type", we assume "DIRECT"
markers are used
+ // If there is no marker type file "MARKERS.type", first assume "DIRECT"
markers are used.
+ // If not, then fallback to "TIMELINE_SERVER_BASED" markers.
Review Comment:
I inspected the code again to see if there will be a chance where marker
type will be missing in timeline server based markers. [looks like
](https://github.com/apache/hudi/blob/ae7395df1e13112a1d99675edb04af05d0242703/hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/marker/MarkerDirState.java#L213)
we first create the marker type file before creating any markers. may be just
the directory will exists w/o any marker type file and w/o any makers. But
there should not be a case where marker type is missing and there are valid
markers found incase of TimelineBasedMarkers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
