alexeykudinkin commented on code in PR #6311:
URL: https://github.com/apache/hudi/pull/6311#discussion_r939457330
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -134,14 +134,14 @@ class ColumnStats {
HashMap<String, ColumnStats> allColumnStats = new HashMap<>();
- // Collect stats for all columns by iterating through records while
accounting
- // corresponding stats
- records.forEach((record) -> {
- // For each column (field) we have to index update corresponding column
stats
- // with the values from this record
- targetFields.forEach(field -> {
- ColumnStats colStats = allColumnStats.computeIfAbsent(field.name(),
(ignored) -> new ColumnStats());
-
+ // For each column (field) we have to index update corresponding column
stats
+ // with the values from this record
+ targetFields.forEach(field -> {
Review Comment:
@danny0405 it does not generate new `ColumnStats` per record --
`ColumnStats` is generated ones per record. Re-ordering does not change anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
