YannByron commented on code in PR #6256: URL: https://github.com/apache/hudi/pull/6256#discussion_r939502111
########## rfc/rfc-51/rfc-51.md: ########## @@ -148,20 +152,27 @@ hudi_cdc_table/ Under a partition directory, the `.log` file with `CDCBlock` above will keep the changing data we have to materialize. -There is an option to control what data is written to `CDCBlock`, that is `hoodie.table.cdc.supplemental.logging`. See the description of this config above. +#### Write-on-indexing vs Write-on-compaction Review Comment: > This could be confusing for customers who dont know the implementation details. I agree with this. we should try to keep the behavior of hudi cdc consistent with customers's perception, and provide explanations only where inconsistent (for ex. bucket index) Adding the new table service `ChangeTrackLoggingService`, that is worth thinking about. And customers also need to know this, know when they can deal with the hudi cdc stream. About supplimental.logging=true, let us provide the two modes to deal with situations where customers are more concerned about query efficiency or write efficiency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
