nsivabalan commented on code in PR #5884:
URL: https://github.com/apache/hudi/pull/5884#discussion_r939581543
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java:
##########
@@ -495,4 +501,33 @@ public Option<HoodieBaseFile> getLatestBaseFile(String
partitionPath, String fil
throw new HoodieRemoteException(e);
}
}
+
+ /**
+ * For remote HTTP requests, to avoid repeatedly instantiating objects.
+ */
+ private class HttpRequestCheckedFunction implements
RetryHelper.CheckedFunction<Response> {
+ private String url;
+ private RequestMethod method;
+ private final int timeout;
Review Comment:
can you suffix the unit to the variable. timeoutMs or timeoutSecs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
