flashJd commented on PR #6324: URL: https://github.com/apache/hudi/pull/6324#issuecomment-1208044528
> If the end commit is active and is used as the filtering instant for scan, shouldn't `getLatestFileSliceBeforeOrOn` work here ? yes, it works, but it can't handle the condition when end commit is archived, if we use `getLatestFileSliceBeforeOrOn`, it may be a savepoint or just no fileSlice(be cleaned), thus not right, `getLatestFileSliceAfterOrOn` can hande it. if the end commit is active, as we have alreay filtered rangeEnd(List<HoodieInstant> instants) using `filterInstantsWithRange`, so it must be an `On` , so in this condition, `getLatestFileSliceAfterOrOn` also works. if `getLatestFileSliceAfterOrOn` not found a fileSlice, we must then search before/reverse, as it may have a fileSlice before which is in the incremental query range(it must be the latest fileSlice in this fileGroup), we should judge if this fileSlice is before the read.start-commit, if it is, we skip this fileSlice, otherwise we use this fileSlice to search. so why `getLatestFileSliceAfterOrOnThenBefore` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
