danny0405 commented on code in PR #6393:
URL: https://github.com/apache/hudi/pull/6393#discussion_r945387535
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java:
##########
@@ -179,9 +176,7 @@ private <T> T executeRequest(String requestPath,
Map<String, String> queryParame
String url = builder.toString();
LOG.info("Sending request : (" + url + ")");
- // Reset url and method, to avoid repeatedly instantiating objects.
- urlCheckedFunc.setUrlAndMethod(url, method);
- Response response = retryHelper != null ?
retryHelper.tryWith(urlCheckedFunc).start() : urlCheckedFunc.get();
+ Response response = retryHelper != null ? retryHelper.tryWith(() ->
get(timeoutSecs, url, method)).start() : get(timeoutSecs, url, method);
String content = response.returnContent().asString();
Review Comment:
The logic is same as before, we should figure out why this fs view client
has concurrency request conflicts. The client expects to keep thread safe by
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
