vinothchandar commented on a change in pull request #1427: [HUDI-727]: Copy
default values of fields if not present when rewriting incoming record with new
schema
URL: https://github.com/apache/incubator-hudi/pull/1427#discussion_r404238197
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -214,6 +218,20 @@ private static GenericRecord rewrite(GenericRecord
record, Schema schemaWithFiel
return newRecord;
}
+ /*
+ This function takes the union of all the fields except hoodie metadata fields
+ */
+ private static List<Field> getAllFieldsToWrite(Schema oldSchema, Schema
newSchema) {
Review comment:
in that case, let have the name reflect that.. `getCombinedFields()`.. `All`
does not bring out what this is doing IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
