modi95 commented on a change in pull request #1310: [HUDI-601] Improve unit
test coverage for HoodieAvroWriteSupport, HoodieRealtimeRecordReader,
RealtimeCompactedRecordReader
URL: https://github.com/apache/incubator-hudi/pull/1310#discussion_r404298362
##########
File path:
hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/realtime/TestHoodieRealtimeRecordReader.java
##########
@@ -251,6 +252,9 @@ private void testReader(boolean partitioned) throws
Exception {
key = recordReader.createKey();
value = recordReader.createValue();
}
+ recordReader.getPos();
+ assertEquals(1.0, recordReader.getProgress(), 0.05);
Review comment:
It is strictly equal to 1. It's just that the `assertEquals` function for
floats/doubles requires a error margin since floats/doubles are not exact
values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
