alexeykudinkin commented on code in PR #6170:
URL: https://github.com/apache/hudi/pull/6170#discussion_r950488643
##########
hudi-examples/hudi-examples-spark/pom.xml:
##########
@@ -230,6 +230,27 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- Logging dependencies -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
Review Comment:
This comment still holds -- let's clean up deps that are already in
hudi-common and leave only `log4j-core` one
##########
hudi-cli/pom.xml:
##########
@@ -207,28 +207,21 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
+ <scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</dependency>
-
- <dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-core</artifactId>
- <scope>test</scope>
- </dependency>
-
<dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-api</artifactId>
- <scope>test</scope>
+ <groupId>org.slf4j</groupId>
+ <artifactId>jul-to-slf4j</artifactId>
+ <scope>runtime</scope>
Review Comment:
Same here
##########
hudi-gcp/pom.xml:
##########
@@ -66,10 +66,6 @@ See
https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-core</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
Review Comment:
Same here -- we don't need these ones anymore. Let's scan whole project and
clean them up
##########
hudi-cli/pom.xml:
##########
@@ -207,28 +207,20 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</dependency>
-
- <dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-core</artifactId>
- <scope>test</scope>
- </dependency>
-
<dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-api</artifactId>
- <scope>test</scope>
+ <groupId>org.slf4j</groupId>
Review Comment:
We should add all bridges (log4j1, slf4j, jul) to `hoodie-common` and remove
them from elsewhere to make sure all modules do have them
##########
hudi-cli/pom.xml:
##########
@@ -207,28 +207,21 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
+ <scope>runtime</scope>
Review Comment:
This should be compile, shouldn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
