vinothchandar commented on a change in pull request #1495: [HUDI-770] Organize
upsert/insert API implementation under a single package
URL: https://github.com/apache/incubator-hudi/pull/1495#discussion_r405954061
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -165,6 +165,19 @@ private boolean commit(String instantTime,
JavaRDD<WriteStatus> writeStatuses,
activeTimeline.saveAsComplete(new HoodieInstant(true, actionType,
instantTime),
Option.of(metadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+ doPostCommitAndEmitCommitMetrics(instantTime, metadata, extraMetadata,
actionType);
+
+ LOG.info("Committed " + instantTime);
+ } catch (IOException e) {
+ throw new HoodieCommitException("Failed to complete commit " +
config.getBasePath() + " at time " + instantTime,
+ e);
+ }
+ return true;
+ }
+
+ void doPostCommitAndEmitCommitMetrics(String instantTime,
HoodieCommitMetadata metadata,
Review comment:
break this into two methods? one to do the post commit and one to emit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
