xushiyan commented on code in PR #6139:
URL: https://github.com/apache/hudi/pull/6139#discussion_r955237307


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -129,6 +129,8 @@ public static class HiveSyncConfigParams {
     public Boolean createManagedTable;
     @Parameter(names = {"--batch-sync-num"}, description = "The number of 
partitions one batch when synchronous partitions to hive")
     public Integer batchSyncNum;
+    @Parameter(names = {"--partition-cascade"}, description = "Partition 
cascade when table columns change.")
+    public Boolean partitionCascade;

Review Comment:
   in general we should avoid adding parameters/configs to tweak the logic 
inside the sync. There are so many configs already exposing the impl. details 
and making meta sync hard to use. 
   
   For this logic of determining cascade, can you figure out a way to detect it 
from schema/column changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to