the-other-tim-brown commented on code in PR #6111: URL: https://github.com/apache/hudi/pull/6111#discussion_r955436277
########## rfc/rfc-57/rfc-57.md: ########## @@ -0,0 +1,85 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +# RFC-57: DeltaStreamer Protobuf Support + + + +## Proposers + +- @the-other-tim-brown + +## Approvers +- @bhasudha +- @vinothchandar + +## Status + +JIRA: https://issues.apache.org/jira/browse/HUDI-4399 + +> Please keep the status updated in `rfc/README.md`. + +## Abstract + +Support consuming Protobuf messages from Kafka with the DeltaStreamer. + +## Background +Hudi's DeltaStreamer currently supports consuming Avro and JSON data from Kafka but it does not support Protobuf. Adding support will require: +1. Parsing the data from Kafka into Protobuf Messages +2. Generating a schema from a Protobuf Message class +3. Converting from Protobuf to Avro + +## Implementation + +### Parsing Data from Kafka +Users will provide a classname for the Protobuf Message that is contained within a jar that is on the path. We will then implement a deserializer that parses the bytes from the kafka message into a protobuf Message. + +Configuration options: +hoodie.deltastreamer.schemaprovider.proto.className - The class to use Review Comment: Do you have experience using that confluent value deserializer? We can add that in as an option but I don't have experience with it so may need your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
