honeyaya commented on code in PR #6139:
URL: https://github.com/apache/hudi/pull/6139#discussion_r955694404


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -129,6 +129,8 @@ public static class HiveSyncConfigParams {
     public Boolean createManagedTable;
     @Parameter(names = {"--batch-sync-num"}, description = "The number of 
partitions one batch when synchronous partitions to hive")
     public Integer batchSyncNum;
+    @Parameter(names = {"--partition-cascade"}, description = "Partition 
cascade when table columns change.")
+    public Boolean partitionCascade;

Review Comment:
   Hi, good idea about the configs settings.
   
   And the logic cascade could not be detected from schema/column changes as 
far as I think, but the **table parameters** might help set this config in my 
opinion, then the user needs to create/alter the table with TBLPROPERTIES: 
"hoodie.datasource.hive_sync.partition_cascade=false"  through HiveSQL,  and 
this is not directly to use.
   
   If we compare these two plans, I prefer the original plan, then what's your 
opinion? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to