honeyaya commented on code in PR #6347:
URL: https://github.com/apache/hudi/pull/6347#discussion_r956987556
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HMSDDLExecutor.java:
##########
@@ -192,18 +194,31 @@ public void addPartitionsToTable(String tableName,
List<String> partitionsToAdd)
LOG.info("Adding partitions " + partitionsToAdd.size() + " to table " +
tableName);
try {
StorageDescriptor sd = client.getTable(databaseName, tableName).getSd();
- List<Partition> partitionList = partitionsToAdd.stream().map(partition
-> {
+ if (syncConfig.getIntOrDefault(HIVE_BATCH_SYNC_PARTITION_NUM) <= 0) {
+ throw new HoodieHiveSyncException("batch-sync-num for sync hive table
must be greater than 0, pls check your parameter");
+ }
Review Comment:
I try to add the validation in the constructor, but there are two
constructor methods:
- public HiveSyncConfig(Properties props) {}
- public HiveSyncConfig(Properties props, Configuration hadoopConf) {}
in the HiveSyncConfig.java file,
If we add the validation, then we need to add the validation at the above
two methods just as the code.
I do know if I get your meaning clearly, please help review again, thanks.
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HMSDDLExecutor.java:
##########
@@ -191,19 +195,27 @@ public void addPartitionsToTable(String tableName,
List<String> partitionsToAdd)
}
LOG.info("Adding partitions " + partitionsToAdd.size() + " to table " +
tableName);
try {
+
ValidationUtils.checkArgument(syncConfig.getIntOrDefault(HIVE_BATCH_SYNC_PARTITION_NUM)
<= 0,
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
