nbalajee commented on code in PR #5958:
URL: https://github.com/apache/hudi/pull/5958#discussion_r957898716


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java:
##########
@@ -266,6 +272,20 @@ public class HoodieCompactionConfig extends HoodieConfig {
       .sinceVersion("0.11.0")
       .withDocumentation("When rewriting data, preserves existing 
hoodie_commit_time");
 
+  public static final ConfigProperty<String> PARTITIONS_FOR_COMPACTION = 
ConfigProperty

Review Comment:
   Instead of explicitly specifying that log compaction is allowed only on say 
record_index partition and not on files partition, should we have the ability 
to run log-compaction on any of the partition, but whether log-compaction gets 
triggered could be based on some other criteria.  (compact only if log file 
blocks contain K records, or has size > X etc).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to