yihua commented on code in PR #6506:
URL: https://github.com/apache/hudi/pull/6506#discussion_r958036128
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java:
##########
@@ -92,6 +92,18 @@ public HoodieReadClient(HoodieSparkEngineContext context,
String basePath, SQLCo
this.sqlContextOpt = Option.of(sqlContext);
}
+ /**
+ * @param context
Review Comment:
nit: add meaningful docs here?
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java:
##########
@@ -92,6 +92,18 @@ public HoodieReadClient(HoodieSparkEngineContext context,
String basePath, SQLCo
this.sqlContextOpt = Option.of(sqlContext);
}
+ /**
+ * @param context
+ * @param basePath
+ * @param sqlContext
+ * @param indexType
+ */
+ public HoodieReadClient(HoodieSparkEngineContext context, String basePath,
SQLContext sqlContext, HoodieIndex.IndexType indexType) {
Review Comment:
Is this going to be used in any query engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
