danny0405 commented on code in PR #6520:
URL: https://github.com/apache/hudi/pull/6520#discussion_r958086044
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -128,12 +128,14 @@ public Result inputSplits(
return Result.EMPTY;
}
+ // The value may be 'earliest' or Null or outOfRange.
final String startCommit =
this.conf.getString(FlinkOptions.READ_START_COMMIT);
- final String endCommit = this.conf.getString(FlinkOptions.READ_END_COMMIT);
Review Comment:
Just fix the `startCommit` should work as expected, no need to change to
much logic.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -128,12 +128,14 @@ public Result inputSplits(
return Result.EMPTY;
}
+ // The value may be 'earliest' or Null or outOfRange.
final String startCommit =
this.conf.getString(FlinkOptions.READ_START_COMMIT);
- final String endCommit = this.conf.getString(FlinkOptions.READ_END_COMMIT);
Review Comment:
Just fix the `startCommit` should work as expected, no need to change so
much logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
