danny0405 commented on code in PR #6510:
URL: https://github.com/apache/hudi/pull/6510#discussion_r958249142


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -117,7 +118,9 @@ private void initTableNameVars(HiveSyncConfig config) {
           this.roTableName = Option.empty();
           break;
         case MERGE_ON_READ:
-          this.snapshotTableName = tableName + SUFFIX_SNAPSHOT_TABLE;
+          this.snapshotTableName = 
config.getBoolean(HIVE_SKIP_RT_SUFFIX_FOR_READ_SNAPSHOT_TABLE)
+                  ? tableName
+                  : tableName + SUFFIX_SNAPSHOT_TABLE;

Review Comment:
   We can throw exception if both options are valuable, but before do that, 
let's figure out the background why 
`HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE` is introduced ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to