xushiyan commented on code in PR #6550: URL: https://github.com/apache/hudi/pull/6550#discussion_r961187592
########## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark3Analysis.scala: ########## @@ -129,50 +129,6 @@ class HoodieSpark3Analysis(sparkSession: SparkSession) extends Rule[LogicalPlan] } } -/** - * Rule for resolve hoodie's extended syntax or rewrite some logical plan. - */ -case class HoodieSpark3ResolveReferences(sparkSession: SparkSession) extends Rule[LogicalPlan] Review Comment: can you help clarify why this Rule is no longer needed? ########## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark3Analysis.scala: ########## @@ -129,50 +129,6 @@ class HoodieSpark3Analysis(sparkSession: SparkSession) extends Rule[LogicalPlan] } } -/** - * Rule for resolve hoodie's extended syntax or rewrite some logical plan. - */ -case class HoodieSpark3ResolveReferences(sparkSession: SparkSession) extends Rule[LogicalPlan] Review Comment: also should this file be under spark3-common? or name as HoodieSpark32PlusAnalysis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
