voonhous commented on code in PR #6566:
URL: https://github.com/apache/hudi/pull/6566#discussion_r962455602


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/HoodieFlinkClusteringJob.java:
##########
@@ -335,5 +391,17 @@ public void shutdownAsyncService(boolean error) {
     public void shutDown() {
       shutdownAsyncService(false);
     }
+
+    /**
+     * Execute a dummy pipeline to prevent "no execute() calls" exceptions 
from being thrown if
+     * clustering is not performed.
+     */

Review Comment:
   Hmmm, CMIIW, `execute()` is only triggered at the end of the `cluster()` 
function.
   
   ```java
   env.execute("flink_hudi_clustering_" + clusteringInstant.getTimestamp());
   ```
   
   If `cluster()` function terminates before reaching the end, the `execute()` 
function will not be called.
   
   Hence, there will be a `no execute() exception` as shown in the image. 
   
   Jobs are submitted via Flink web portal using the hoodie flink bundle jar. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to