[GitHub] [hudi] KnightChess commented on a diff in pull request #6589: [HUDI-4776] fix merge into use unresolved assignment

Tue, 06 Sep 2022 01:10:07 -0700 


KnightChess commented on code in PR #6589:
URL: https://github.com/apache/hudi/pull/6589#discussion_r963390648


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -282,13 +282,21 @@ case class HoodieResolveReferences(sparkSession: 
SparkSession) extends Rule[Logi
           // the hoodie's meta field in sql statement, it is a system field, 
cannot set the value
           // by user.
           if (HoodieSparkUtils.isSpark3) {
-            val assignmentFieldNames = assignments.map(_.key).map {
+            val resolvedAssignments = assignments.map { assign =>

Review Comment:
   code in line 273 has consider the `empty`. In `HoodieInternalV2Table`,the 
attribute capabilities contain `ACCEPT_ANY_SCHEMA` which will skip resolve  
expression in spark side.
   
![image](https://user-images.githubusercontent.com/20125927/188581462-c7cff8c0-8872-439d-9990-5045781d2a0f.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to