voonhous commented on code in PR #6566:
URL: https://github.com/apache/hudi/pull/6566#discussion_r964348442
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/HoodieFlinkClusteringJob.java:
##########
@@ -335,5 +391,17 @@ public void shutdownAsyncService(boolean error) {
public void shutDown() {
shutdownAsyncService(false);
}
+
+ /**
+ * Execute a dummy pipeline to prevent "no execute() calls" exceptions
from being thrown if
+ * clustering is not performed.
+ */
Review Comment:
While the exception throw does not affect anything (For most parts).
I would argue that it is more confusing for the it to throw an exception
when there are no compaction/clustering plans to execute.
If downstream applications are used to determine the status of the job, we
would deem that this job has failed given that an exception is thrown (unless
we explicitly scan the log to look for keywords to indicate that the failure is
intended).
My goal here is to remove this such unintended errors to avoid operational
confusion. In such a case, instead of adding an execution logic to avoid
confusion, can we add an additional catch block to catch
`ApplicationExecutionException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
