xushiyan commented on code in PR #6468:
URL: https://github.com/apache/hudi/pull/6468#discussion_r964515489
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -208,6 +209,7 @@ public void sync() throws Exception {
throw ex;
} finally {
deltaSyncService.ifPresent(DeltaSyncService::close);
+ Metrics.shutdown();
Review Comment:
functionality-wise, it should be ok. i think it's a question of where is the
single place we can clean up all resources.
`org.apache.hudi.utilities.deltastreamer.DeltaSync#close` looks like the right
place. It looks more of a minor clean up to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
