TJX2014 opened a new pull request, #6634:
URL: https://github.com/apache/hudi/pull/6634

   ### Change Logs
   Fix KEY_GENERATOR_CLASS_NAME will be assigned default as 
`ComplexKeyGenerator` in 
`org.apache.spark.sql.catalyst.catalog.HoodieCatalogTable#extraTableConfig`
   The `org.apache.hudi.DataSourceOptionsHelper#inferKeyGenClazz` is not used 
at all:
   at `org.apache.hudi.DataSourceWriteOptions#keyGeneraterInferFunc`, because 
not set default value, will not be called;at 
`org.apache.spark.sql.hudi.command.SqlKeyGenerator#getRealKeyGenClassName`, 
also not be called, because `beforeKeyGenClassName != null && 
beforeKeyGenClassName.nonEmpty` is excluded from 
`org.apache.spark.sql.hudi.command.SqlKeyGenerator#originKeyGen`
   
   ### Impact
   SparkSql will also follow infer way when KEY_GENERATOR_CLASS_NAME not user 
defined.
   
   **Risk level: none | low | medium | high**
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to