xushiyan commented on code in PR #6550:
URL: https://github.com/apache/hudi/pull/6550#discussion_r966341103
##########
pom.xml:
##########
@@ -377,9 +377,17 @@
<exclude>org.sl4fj:slf4j-jcl</exclude>
<exclude>log4j:log4j</exclude>
<exclude>ch.qos.logback:logback-classic</exclude>
+ <!-- NOTE: We're banning any HBase deps versions other
than the approved ${hbase.version},
+ which is aimed at preventing the classpath
collisions w/ transitive deps usually) -->
+ <exclude>org.apache.hbase:hbase-common:*</exclude>
+ <exclude>org.apache.hbase:hbase-client:*</exclude>
+ <exclude>org.apache.hbase:hbase-server:*</exclude>
</excludes>
<includes>
<include>org.slf4j:slf4j-simple:*:*:test</include>
+
<exclude>org.apache.hbase:hbase-common:${hbase.version}</exclude>
+
<exclude>org.apache.hbase:hbase-client:${hbase.version}</exclude>
+
<exclude>org.apache.hbase:hbase-server:${hbase.version}</exclude>
</includes>
Review Comment:
why are these "exclude"s repeated here under "includes" ?
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -140,14 +140,14 @@
<!-- NOTE: We have to relocate all classes w/in
org.apache.spark.sql.avro to avoid
potential classpath collisions in case users would
like to also use "spark-avro" w/in
their runtime, since Hudi carries some of the same
classes as "spark-avro" -->
- <relocation>
- <pattern>javax.servlet.</pattern>
- <shadedPattern>org.apache.hudi.javax.servlet.</shadedPattern>
- </relocation>
<relocation>
<pattern>org.apache.spark.sql.avro.</pattern>
<shadedPattern>org.apache.hudi.org.apache.spark.sql.avro.</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>javax.servlet.</pattern>
+ <shadedPattern>org.apache.hudi.javax.servlet.</shadedPattern>
+ </relocation>
Review Comment:
unnecessary moving of these lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
