fengjian428 commented on code in PR #4676:
URL: https://github.com/apache/hudi/pull/4676#discussion_r967652730
##########
hudi-common/src/main/java/org/apache/hudi/common/util/SpillableMapUtils.java:
##########
@@ -154,8 +155,13 @@ private static Object getPreCombineVal(GenericRecord rec,
String preCombineField
if (preCombineField == null) {
return 0;
}
- Schema.Field field = rec.getSchema().getField(preCombineField);
- return field == null ? 0 : rec.get(field.pos());
+ // Handle multiple ordering/preCombineFields
+ if (preCombineField.contains(";")) {
+ return HoodieAvroUtils.getMultipleNestedFieldVals(rec, preCombineField,
false);
+ } else {
Review Comment:
OK, I revert all changes wrt multiple ordering support, will create
another PR since I feel we still need to support out-of-order events scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
