yihua commented on code in PR #6602:
URL: https://github.com/apache/hudi/pull/6602#discussion_r970132343
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/SizeAwareFSDataOutputStream.java:
##########
@@ -44,7 +44,7 @@ public class SizeAwareFSDataOutputStream extends
FSDataOutputStream {
public SizeAwareFSDataOutputStream(Path path, FSDataOutputStream out,
ConsistencyGuard consistencyGuard,
Runnable closeCallback) throws
IOException {
- super(out, null);
+ super(out, null, out.getPos());
Review Comment:
Even for correctness, we should pass the right start position
(`out.getPos()`). Without this, does it overwrite the existing log blocks from
the position of 0 when trying to append new log blocks on HDFS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
