xushiyan commented on code in PR #6662:
URL: https://github.com/apache/hudi/pull/6662#discussion_r972587570
##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncClient.java:
##########
@@ -158,4 +171,23 @@ public List<PartitionEvent>
getPartitionEvents(List<Partition> tablePartitions,
}
return events;
}
+
+ /**
+ * Get Last commit's Metadata.
+ */
+ private static Option<HoodieCommitMetadata>
getLatestCommitMetadata(HoodieTableMetaClient metaClient) {
Review Comment:
i think a more relevant logic we need for partition sync is:
getCommitMetadataSinceLastSync(). it should return time-ordered commit metadata
for extracting (partition, written|dropped) to be further produced partition
events for sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
