codope commented on code in PR #6548:
URL: https://github.com/apache/hudi/pull/6548#discussion_r972613010
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -206,15 +206,7 @@ private List<String>
getPartitionPathsForIncrementalCleaning(HoodieCleanMetadata
*/
private List<String> getPartitionPathsForFullCleaning() {
// Go to brute force mode of scanning all partitions
- try {
- // Because the partition of BaseTableMetadata has been deleted,
- // all partition information can only be obtained from
FileSystemBackedTableMetadata.
Review Comment:
@nsivabalan I think your suggestion makes sense given that we now do lazy
cleaning. If `files` partition of metadata table exists then, most likely, the
record is there with `isDeleted` set to true. The metadata based fs view should
understand the
[isDeleted](https://github.com/apache/hudi/blob/master/hudi-common/src/main/avro/HoodieMetadata.avsc#L50)
flag of `HoodieMetadataFileInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
