nsivabalan commented on code in PR #6561:
URL: https://github.com/apache/hudi/pull/6561#discussion_r972714037
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -249,7 +249,7 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>>
executeClustering(HoodieC
HoodieData<WriteStatus> statuses = updateIndex(writeStatusList,
writeMetadata);
writeMetadata.setWriteStats(statuses.map(WriteStatus::getStat).collectAsList());
writeMetadata.setPartitionToReplaceFileIds(getPartitionToReplacedFileIds(clusteringPlan,
writeMetadata));
- validateWriteResult(clusteringPlan, writeMetadata);
+ // if we don't cache the write statuses above, validation will call
isEmpty which might retrigger the execution again.
Review Comment:
incase of flink, we are already operation on a List<WriteStatus> and so
there is no fixes required in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
