TJX2014 commented on code in PR #6630:
URL: https://github.com/apache/hudi/pull/6630#discussion_r972723942
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/testutils/HoodieWriteableTestTable.java:
##########
@@ -152,27 +151,21 @@ public Path withInserts(String partition, String fileId,
List<HoodieRecord> reco
return baseFilePath;
}
- public Map<String, List<HoodieLogFile>> withLogAppends(List<HoodieRecord>
records) throws Exception {
+ public Map<String, List<HoodieLogFile>> withAppends(String partition, String
fileId, List<HoodieRecord> records) throws Exception {
Map<String, List<HoodieLogFile>> partitionToLogfilesMap = new HashMap<>();
- for (List<HoodieRecord> groupedRecords : records.stream()
Review Comment:
Seems `withAppends ` more consistent with former `withInserts`, I will
recover to `withLogAppends ` follow your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
