[ 
https://issues.apache.org/jira/browse/HUDI-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084405#comment-17084405
 ] 

Ramachandran M S commented on HUDI-409:
---------------------------------------

[~vinoth] can you please give more details (test cases) to reproduce if there 
are any errors. I fixed this as part of 0.5.2 and added tests to simulate the 
failure situations. Highly interested in knowing what case is crashing the 
reader now.

 

Or if this is about adding a magic header, me and [~nagarwal] discussed and 
decided it was not required for the following reasons
 * Current header + magic hash (#HUDI#) + footer itself can be used to detect 
corruptions
 * Discussed a solution where just modifying current reader logic can avoid 
clash of data with header (details are in the 
[PR|https://issues.apache.org/jira/browse/HUDI-409])
 * Modifying/adding new magic header would involve considerable amount of work 
to maintain different versions of log files in production at the same time. 
Could possibly introduce some bugs

> Replace Log Magic header with a secure hash to avoid clashes with data
> ----------------------------------------------------------------------
>
>                 Key: HUDI-409
>                 URL: https://issues.apache.org/jira/browse/HUDI-409
>             Project: Apache Hudi (incubating)
>          Issue Type: Improvement
>          Components: Common Core
>            Reporter: Nishith Agarwal
>            Assignee: Ramachandran M S
>            Priority: Major
>             Fix For: 0.6.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to