xushiyan commented on a change in pull request #1500: [HUDI-772] Make UserDefinedBulkInsertPartitioner configurable for DataSource URL: https://github.com/apache/incubator-hudi/pull/1500#discussion_r409313000
########## File path: hudi-spark/src/test/java/DataSourceUtilsTest.java ########## @@ -17,18 +17,58 @@ */ import org.apache.hudi.DataSourceUtils; +import org.apache.hudi.DataSourceWriteOptions; +import org.apache.hudi.client.HoodieWriteClient; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.table.NoOpBulkInsertPartitioner; import org.apache.avro.Schema; import org.apache.avro.generic.GenericData; import org.apache.avro.generic.GenericRecord; -import org.junit.jupiter.api.Test; +import org.apache.spark.api.java.JavaRDD; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; Review comment: @kwondw my bad...i should have migrated mockito together when i added the junit 5 dep.. I've opened up #1521 to migrate mockito. @vinothchandar @yanghua To make all ongoing PRs ready to use JUnit 5, we would hope to get #1521 merged sooner. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
