codope commented on code in PR #6388:
URL: https://github.com/apache/hudi/pull/6388#discussion_r974019645
##########
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java:
##########
@@ -50,10 +50,6 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord>
record) {
@Override
public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload oldValue) {
- if (oldValue.recordBytes.length == 0) {
- // use natural order for delete record
- return this;
Review Comment:
Also, I think a better way would be to subclass this and create a separate
implementation for CDC payload. What do you think?
cc @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
