alexeykudinkin commented on code in PR #6196:
URL: https://github.com/apache/hudi/pull/6196#discussion_r974651748


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieCommonConfig.java:
##########
@@ -38,7 +38,7 @@ public class HoodieCommonConfig extends HoodieConfig {
 
   public static final ConfigProperty<Boolean> RECONCILE_SCHEMA = ConfigProperty
       .key("hoodie.datasource.write.reconcile.schema")
-      .defaultValue(false)
+      .defaultValue(true)

Review Comment:
   @yihua it's more of a discussion what should be the default behavior:
   
    - Should we (by default) favor existing table's schema a SoT and rewrite 
incoming batch into it (unless Schema Evolution is enabled, in that case we 
will try to evolve the schema)
    - Should we (by default) favor incoming batch's schema as the schema we 
want table to be rewritten in
   
   I still think that the #1 is a safer option as a default (optimizing for 
least amount of surprise to the user)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to