vinothchandar commented on a change in pull request #1469: [HUDI-686] Implement
BloomIndexV2 that does not depend on memory caching
URL: https://github.com/apache/incubator-hudi/pull/1469#discussion_r409759610
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieTimer.java
##########
@@ -69,4 +76,13 @@ public long endTimer() {
}
return timeInfoDeque.pop().stop();
}
+
+ public long deltaTime() {
Review comment:
endTimer() already gives you a delta time right? why do we need this new
method? We should consolidate this more.. right now, this feels like two timer
classes within one..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
