alexeykudinkin commented on code in PR #5629:
URL: https://github.com/apache/hudi/pull/5629#discussion_r975768738
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -505,7 +514,9 @@ public class HoodieWriteConfig extends HoodieConfig {
private HoodieMetadataConfig metadataConfig;
private HoodieMetastoreConfig metastoreConfig;
private HoodieCommonConfig commonConfig;
+ private HoodieStorageConfig storageConfig;
private EngineType engineType;
+ private HoodieRecordMerger recordMerger;
Review Comment:
Let's avoid premature optimizations -- `RecordMerger` is specifically
designed as stateless component and as such is lightweight enough to be
initialized on-demand. Only thing we need to take care of is just making sure
we don't init it for every record.
The problem with caching it inside `HoodieWriteConfig` is that
HoodieWriteConfig has nothing to do w/ RecordMerger and we should not open this
can of warm when it's used as a state carriage for other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
