danny0405 commented on PR #6697: URL: https://github.com/apache/hudi/pull/6697#issuecomment-1254607968
Fired a PR: https://github.com/apache/hudi/pull/6740 to address my concerns, there are still 3 issues needs to be fixed: 1. the cdc log records are cached all into a spillable map during merge handle, there is risk for OOM; 2. the json serialization is not efficient 3. the tests are too few, we should cover at least these cases: all deletes, all inserts, upserts in sequence, upserts in disorder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
